[GitHub] orc pull request #273: ORC-343 Enable C++ writer to support RleV2

[majetideepak]

Github user majetideepak commented on a diff in the pull request:

    https://github.com/apache/orc/pull/273#discussion_r191829402
  
    --- Diff: c++/src/Writer.cc ---
    @@ -38,9 +38,10 @@ namespace orc {
         FileVersion fileVersion;
         double dictionaryKeySizeThreshold;
         bool enableIndex;
    +    RleVersion rleVersion;
    --- End diff --
    
    I think the file version should determine the `RleVersion`. Refer 
`isNewWriteFormat` and `isDirectV2` on the Java side.



---