Github user omalley commented on a diff in the pull request: https://github.com/apache/orc/pull/299#discussion_r208397080 --- Diff: java/core/src/java/org/apache/orc/impl/ColumnStatisticsImpl.java --- @@ -584,16 +630,40 @@ public void merge(ColumnStatisticsImpl other) { if (str.minimum != null) { maximum = new Text(str.getMaximum()); minimum = new Text(str.getMinimum()); - } else { + } --- End diff -- Ok, you should keep the "else" on the same line as the "}", but I don't think you need this new branch.
---