Fang Zheng created ORC-429: ------------------------------ Summary: Refactor code in TypeImpl.cc Key: ORC-429 URL: https://issues.apache.org/jira/browse/ORC-429 Project: ORC Issue Type: Improvement Reporter: Fang Zheng
Propose to make two changes to the code in TypeImpl.cc 1. In convertType() function: in the case of proto::Type_Kind_STRUCT, two vectors are created but never used. They shall be removed. 2. In TypeImpl::parseType() function: the function calls input.substr() to copy the substring before parsing it. This string copy can be avoided by directly parsing on the input string. Please see pull request for details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)