Great! Thank you, Vaibhav. Bests, Dongjoon.
On Thu, Dec 20, 2018 at 9:07 AM Vaibhav Gumashta <vgumas...@hortonworks.com> wrote: > With 3 binding +1s, 1 non-binding +1 and no -1s, the vote has passed. I’ll > promote the rc to a release now. > > Thanks Owen, Dongjoon, Eugene and Prasanth for evaluating the rc. > > --Vaibhav > > On 12/19/18, 5:23 PM, "Prasanth Jayachandran" <j.prasant...@gmail.com> > wrote: > > +1 > > - Verified signature, checksum > - Built from src on MacOS, ran unit tests > - Ran rat check > > One minor thing is java/bench/pom.xml still has version 1.5.4-SNAPSHOT > but > we don't ship jars from bench module as it is under a developer > profile, so > I guess we don't have to roll another rc for that. > > Thanks and Regards, > Prasanth Jayachandran > > > > On Wed, Dec 19, 2018 at 12:47 PM Eugene Koifman < > ekoif...@hortonworks.com> > wrote: > > > +1 > > > > Ran Java portion on Mac, ran ORC tests, built Hive (master) against > 1.5.4 > > and ran some Hive UTs > > > > > > Eugene > > > > > > On 12/18/18, 7:59 PM, "Dongjoon Hyun" <dongjoon.h...@gmail.com> > wrote: > > > > +1 (non-binding) > > > > I checked building and Java unit testing on Mac. > > Also, I built Apache Spark master branch with this and checked > that all > > Spark UT passed. > > > > Thank you! > > > > Bests, > > Dongjoon. > > > > > > On Tue, Dec 18, 2018 at 3:27 PM Owen O'Malley < > owen.omal...@gmail.com> > > wrote: > > > > > +1 > > > > > > I checked: > > > > > > Signatures are correct > > > The tarball matches the tag. > > > The build and unit tests pass on Mac. > > > The build and unit tests pass in all of the docker > environments. > > > > > > .. Owen > > > > > > > On Dec 18, 2018, at 10:15 AM, Vaibhav Gumashta < > > > vgumas...@hortonworks.com> wrote: > > > > > > > > All, > > > > > > > > Should we release the following artifacts as ORC 1.5.4? > > > > > > > > tar: http://home.apache.org/~vgumashta/orc-1.5.4rc1 > > > > tag: > https://github.com/apache/orc/releases/tag/release-1.5.4rc1 > > > > jiras: > > > > > > https://issues.apache.org/jira/issues/?jql=project+%3D+ORC+AND+fixVersion+%3D+1.5.4 > > > > > > > > Thanks! > > > > > > > > > > > > > > > > > > >
