Paul Finkelshteyn created ORC-618:
-------------------------------------
Summary: Make several methods in TreeReader public
Key: ORC-618
URL: https://issues.apache.org/jira/browse/ORC-618
Project: ORC
Issue Type: Improvement
Reporter: Paul Finkelshteyn
I've implemented my own RecordReader and DataReader according to ORC-617 —
based on only FSDataInputStream, not Path. Of course, I've implemented them
being heavily influenced by RecordReaderImpl and DefaultDataReader (yes, it was
almost copy-paste which only says us that it should be absolutely possible to
implement them with only FSDataInputStream).
But during implementation I've found that methds skipRows, setVectorColumnCount
and startStripe of TreeReader are package-private. I can't see a reason for
them not to be public and now I have to call them with reflection which looks
weird and creepy.
Please, change visibility of this methods. It shouldn't break any existing
functionality for current adopters and will improve experience for new
developers.
Thanks!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
