Owen O'Malley created ORC-620:
---------------------------------

             Summary: Modify the row filter API to use BiFunction
                 Key: ORC-620
                 URL: https://issues.apache.org/jira/browse/ORC-620
             Project: ORC
          Issue Type: Bug
            Reporter: Owen O'Malley
            Assignee: Owen O'Malley


The current API for row filtering has a couple of issues:
 * The filter function is passed a VectorizedRowBatch instead of a 
MutableFilterContext.
 * The filter needs to know the precise location for the fields it needs out of 
the schema.

I'd like to propose changing it from:
{code:java}Consumer<VectorizedRowBatch>{code}
to
{code:java}BiFunction<ColumnVector[], MutableFilterContext, Boolean>{code}

That has the advantage that the data that the function should read is 
explicitly passed to it and we remove the dependence on VectorizedRowBatch.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to