pgaref commented on a change in pull request #475:
URL: https://github.com/apache/orc/pull/475#discussion_r411491070



##########
File path: java/core/src/java/org/apache/orc/Reader.java
##########
@@ -237,6 +241,12 @@ public Options schema(TypeDescription schema) {
       return this;
     }
 
+    public Options setFilter(String[] filterColumnNames, 
Consumer<VectorizedRowBatch> filterCallback) {

Review comment:
       As discussed, this makes a lot of sense as it will enable us skipping 
multiple VectorBatches in a single call when there is no much -- as ORC-620 is 
making the filter API more generic I propose to tackle the issue there.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to