omalley commented on pull request #503: URL: https://github.com/apache/orc/pull/503#issuecomment-625499062
Ok, I started [tweaking](https://github.com/omalley/orc/commit/e73bdbdb00ca43f679fc994e7f6988d7b6a45fec) this. I hope that is ok, Pavan. I'd propose: * making BatchReader an abstract class. * making a new PrimitiveBatchReader that handles the special case of a primitive root type * removing the type parameter on BatchReader Thoughts? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
