tobodner opened a new pull request #510:
URL: https://github.com/apache/orc/pull/510
Consuming Apache ORC in a C++ project as CMake submodule (via
add_subdirectory) currently causes two issues:
* A warning about CMake policy CMP0048 not being set, which cannot be
suppressed from the outside:
```
CMake Warning (dev) at third_party/orc/CMakeLists.txt:15 (project):
Policy CMP0048 is not set: project() command manages VERSION variables.
Run "cmake --help-policy CMP0048" for policy details. Use the cmake_policy
command to set the policy and suppress this warning.
The following variable(s) would be set to empty:
PROJECT_VERSION
PROJECT_VERSION_MAJOR
PROJECT_VERSION_MINOR
PROJECT_VERSION_PATCH
This warning is for project developers. Use -Wno-dev to suppress it.
```
* Errors about CMake modules not being found:
```
CMake Error at third_party/orc/CMakeLists.txt:116 (INCLUDE):
INCLUDE could not find load file:
CheckSourceCompiles
CMake Error at third_party/orc/CMakeLists.txt:117 (INCLUDE):
INCLUDE could not find load file:
ThirdpartyToolchain
```
This PR fixes the above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
