omalley commented on a change in pull request #524:
URL: https://github.com/apache/orc/pull/524#discussion_r474311146
##########
File path: cmake_modules/FindZSTD.cmake
##########
@@ -24,7 +24,7 @@ endif()
message (STATUS "ZSTD_HOME: ${ZSTD_HOME}")
if (NOT ZSTD_STATIC_LIB_NAME)
- set (ZSTD_STATIC_LIB_NAME ${CMAKE_STATIC_LIBRARY_PREFIX}zstd)
+ set (ZSTD_STATIC_LIB_NAME
${CMAKE_STATIC_LIBRARY_PREFIX}zstd${CMAKE_STATIC_LIBRARY_SUFFIX})
Review comment:
Yeah, we really need to clean up the CMakefiles. At this point, my
original goal of using static libraries has become much less relevant. We
should probably just default to using dynamic linking everywhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
