wgtmac commented on a change in pull request #508:
URL: https://github.com/apache/orc/pull/508#discussion_r482137349
##########
File path: java/core/src/java/org/apache/orc/impl/RecordReaderImpl.java
##########
@@ -495,6 +495,14 @@ static TruthValue
evaluatePredicateProto(OrcProto.ColumnStatistics statsProto,
" include ORC-517. Writer version: {}",
predicate.getColumnName(), writerVersion);
return TruthValue.YES_NO_NULL;
+ } else if (category == TypeDescription.Category.DOUBLE) {
+ DoubleColumnStatistics dstas = (DoubleColumnStatistics) cs;
+ if (!Double.isFinite(dstas.getMinimum()) ||
!Double.isFinite(dstas.getMaximum())
Review comment:
Ok, I found the fix for java is merged too:
https://github.com/apache/orc/commit/5dd3b29a2f4a97aa716b301c657c1853cc27e6c2.
Would like to close this PR to make it less confusing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
