wgtmac commented on a change in pull request #541:
URL: https://github.com/apache/orc/pull/541#discussion_r482777902
##########
File path: c++/src/CMakeLists.txt
##########
@@ -236,11 +231,11 @@ endif(BUILD_LIBHDFSPP)
add_library (orc STATIC ${SOURCE_FILES})
target_link_libraries (orc
- protobuf
- zlib
- snappy
- lz4
- zstd
+ orc::protobuf
Review comment:
what's the rationale of an orc prefix?
##########
File path: cmake_modules/FindLZ4.cmake
##########
@@ -13,7 +13,7 @@
# LZ4_HOME environment variable is used to check for LZ4 headers and static
library
# LZ4_INCLUDE_DIR: directory containing headers
-# LZ4_LIBS: directory containing LZ4 libraries
+# LZ4_LIBRARY: path to libz4
Review comment:
liblz4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
