Dongjoon, Can you check out the new 1.5 and 1.6 release candidates? I'd like to get the replacement releases out quickly.
Thank you, Owen On Sun, Sep 20, 2020 at 4:32 AM Dongjoon Hyun <[email protected]> wrote: > Hi, Owen, Alan, Jesus and all. > > Sorry for being late, but it seems that 1.6.4 and 1.5.11 introduced a > correctness regression in the following patch. > > ORC-644: Support positional mapping for nested types. > > Although Apache ORC configuration, 'orc.force.positional.evolution', is > false, > positional mapping is applied for the nested struct types currently and > gives a wrong result for all downstream. > > Could you review the following PR? > > https://github.com/apache/orc/pull/545 > ORC-667: Positional mapping for nested struct types should not applied > by default > > Bests, > Dongjoon. > > > On Mon, Sep 14, 2020 at 3:17 PM Owen O'Malley <[email protected]> > wrote: > > > With three +1's the vote passes. Thank you, Alan & Jesus! > > > > On Mon, Sep 14, 2020 at 8:32 PM Jesus Camacho Rodriguez < > > [email protected]> > > wrote: > > > > > +1. > > > > > > Same as for 1.5.11 RC. Downloaded the artifacts, checked signature, > hash, > > > LICENSE, NOTICE. Compiled the java code and run test suite. > > > > > > -Jesús > > > > > > On Mon, Sep 14, 2020 at 10:28 AM Alan Gates <[email protected]> wrote: > > > > > > > +1. Checked the signature and hash, looked over the LICENSE and > NOTICE > > > > files and checked to make sure there were no non-image or font binary > > > files > > > > in the release, and did a check for license headers. Did a build in > > the > > > > Ubuntu 18 Docker image. > > > > > > > > Alan. > > > > > > > > On 2020/09/03 00:57:22, "Owen O'Malley" <[email protected]> > > wrote: > > > > > OK, I accidentally messed up the version setting in the java > > benchmark > > > > > code, so I rolled a > > > > > new RC. > > > > > > > > > > All, Should we release the following artifacts as ORC 1.6.4? > > > > > > > > > > tar: http://home.apache.org/~omalley/orc-1.6.4/ > > > > > tag: https://github.com/apache/orc/releases/tag/release-1.6.4rc1 > > > > > jiras: > > > https://issues.apache.org/jira/browse/ORC/fixforversion/12348176 > > > > > > > > > > Thanks! > > > > > > > > > > > > > > > > > > > > > > > > > >
