pgaref commented on pull request #566: URL: https://github.com/apache/orc/pull/566#issuecomment-723089596
Hey @dongjoon-hyun thanks for looking at this! Wrapper script LGTM -- however I believe we still have to replace the MVN build/test calls with MVNW right? For instance: - https://github.com/apache/orc/blob/master/.github/workflows/master.yml#L46 - https://github.com/apache/orc/blob/master/java/CMakeLists.txt#L49 And as we are only now going to depend on MVNW maybe even remove maven plugin installation from Dockerfiles completely? - https://github.com/apache/orc/blob/master/docker/debian10/Dockerfile#L33 Another thing we have to check is if the MAVEN_OPTS are actually propagated to the wrapper (which I believe they should): https://github.com/apache/orc/blob/master/.github/workflows/master.yml#L22 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
