dongjoon-hyun commented on a change in pull request #570:
URL: https://github.com/apache/orc/pull/570#discussion_r528912903
##########
File path: java/core/src/test/org/apache/orc/impl/TestReaderImpl.java
##########
@@ -368,6 +366,28 @@ public void testOrcTailStripeStats() throws Exception {
stats.get(0).getColumn(5).getTimestampStatistics();
assertEquals(-28800000, tsStats.getMinimumUtc());
assertEquals(-28550000, tsStats.getMaximumUtc());
+
+ // Test Tail and Stats extraction from ByteBuffer
+ ByteBuffer tailBuffer = tail.getSerializedTail();
+ OrcTail extractedTail = ReaderImpl.extractFileTail(tailBuffer);
+
+ assertEquals(tail.getTailBuffer(), extractedTail.getTailBuffer());
+ assertEquals(tail.getTailBuffer().getData(),
extractedTail.getTailBuffer().getData());
+ assertEquals(tail.getTailBuffer().getOffset(),
extractedTail.getTailBuffer().getOffset());
+ assertEquals(tail.getTailBuffer().getEnd(),
extractedTail.getTailBuffer().getEnd());
+
+ assertEquals(tail.getMetadataOffset(),
extractedTail.getMetadataOffset());
+ assertEquals(tail.getMetadataSize(), extractedTail.getMetadataSize());
+
+ Reader dummyReader = new ReaderImpl(null,
Review comment:
For testing, this looks okay for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
