chaoyli commented on a change in pull request #586:
URL: https://github.com/apache/orc/pull/586#discussion_r547618763
##########
File path: c++/test/TestRleEncoder.cc
##########
@@ -280,6 +280,33 @@ namespace orc {
decodeAndVerify(RleVersion_2, memStream, data, numValues, nullptr,
isSigned);
}
+ // This case is used to testing encoding large negative integer.
Review comment:
I have test large positive number, but found it will not use PatchedBase
encoding, so it's OK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
