pavibhai commented on pull request #636: URL: https://github.com/apache/orc/pull/636#issuecomment-769049861
> In general, this patch looks too risky due to the massive size, `+9,192 −669`. I agree that this is a large patch, to give a little more details, this is what the distribution of changes looks like: Percentage|Directory -----------|---------- 16.3% | java/bench/core/src/java/org/apache/orc/bench/core/filter/ 6.2% | java/bench/core/src/test/org/apache/orc/bench/core/filter/ 4.8% | java/bench/ 12.9% | java/core/src/gen/filters/ 6.7% | java/core/src/java/org/apache/orc/filter/impl/ 3.8% | java/core/src/java/org/apache/orc/filter/ 6.2% | java/core/src/java/org/apache/orc/util/ 16.1% | java/core/src/test/org/apache/orc/filter/impl/ 8.0% | java/core/src/test/org/apache/orc/ 7.9% | java/gen/src/main/java/org/apache/orc/gen/ 4.5% | java/mapreduce/src/test/org/apache/orc/mapreduce/ 6.1% | java/ * 27.3% of the lines changes are in the bench module * 28.6% of the remaining changes are in tests, primarily from addition of new tests for evaluating the SArg conversions I am open to suggestions on better to submit this change. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
