pavibhai commented on a change in pull request #635:
URL: https://github.com/apache/orc/pull/635#discussion_r578812099
##########
File path: java/core/src/java/org/apache/orc/impl/TreeReaderFactory.java
##########
@@ -2833,8 +2904,7 @@ public static TypeReader createTreeReader(TypeDescription
readerType,
case DATE:
return new DateTreeReader(fileType.getId(), context);
case DECIMAL:
- if (version == OrcFile.Version.UNSTABLE_PRE_2_0 &&
- fileType.getPrecision() <=
TypeDescription.MAX_DECIMAL64_PRECISION){
+ if (isDecimalAsLong(version, fileType.getPrecision())){
Review comment:
This is used in #636 I will remove from this PR and include it as part
of that PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
