wgtmac commented on pull request #476: URL: https://github.com/apache/orc/pull/476#issuecomment-788927592
> Hey @wgtmac thanks for the reminder! > Just went through the code and left some comments -- I believe we should add some more Tests here to increase confidence. Few example include: testPredEvalWithBooleanStats, testPredEvalWithIntStats etc. > > https://github.com/apache/orc/blob/949c7444ef98680026d9f2b93d7299b76cdfb030/java/core/src/test/org/apache/orc/impl/TestRecordReaderImpl.java#L581 > > On another note, [ORC-40](https://issues.apache.org/jira/browse/ORC-40) seems to be about building SearchArgument so we should move this to a new ticket -- open [ORC-751](https://issues.apache.org/jira/browse/ORC-751) for this I have covered these kinds of cases in the TestPredicateLeaf.cc in a earlier commit. I can add more progressively to gain more confidence. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
