yuokada commented on a change in pull request #655:
URL: https://github.com/apache/orc/pull/655#discussion_r595650885



##########
File path: docker/ubuntu20/Dockerfile
##########
@@ -32,9 +33,9 @@ RUN apt-get install -y \
   make \
   curl \
   maven \
-  openjdk-8-jdk \
+  openjdk-${jdk}-jdk \
   tzdata
-RUN update-java-alternatives --set java-1.8.0-openjdk-amd64
+RUN update-java-alternatives --set java-1.${jdk}.0-openjdk-amd64

Review comment:
       ```
   ~/w/I/o/docker ❯❯❯ docker run -it orc-ubuntu20-jdk11 
update-java-alternatives -l  
   java-1.11.0-openjdk-amd64      1111       
/usr/lib/jvm/java-1.11.0-openjdk-amd64
   
   ~/w/I/o/docker ❯❯❯ docker run -it orc-ubuntu20-jdk11 java -version
   openjdk version "11.0.10" 2021-01-19
   OpenJDK Runtime Environment (build 11.0.10+9-Ubuntu-0ubuntu1.20.04)
   OpenJDK 64-Bit Server VM (build 11.0.10+9-Ubuntu-0ubuntu1.20.04, mixed mode, 
sharing)
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to