bgivertz opened a new pull request #657: URL: https://github.com/apache/orc/pull/657
### What changes were proposed in this pull request? I have added a BUILD_POSITION_INDEPENDENT_LIB option to the CMake file which is turned OFF by default. However, if a user needs to compile the static libraries with PIC, they are able to specify so by turning the option ON. This will effect liborc and all of its external dependencies. If turned on, the option will set the CMAKE_POSITION_INDEPENDENT_CODE flag. ### Why are the changes needed? When building the ORC c++ library, it will compile itself and its third party dependencies as static libraries. However, on linux, it is not possible to link these libraries to a shared object unless they are compiled with position independent code. ### How was this patch tested? It is difficult to add tests in order to ensure that libraries have been compiled with position independent code. However, I have used the feature and confirmed that when the option is turned on, the libraries successfully link with a shared object and when turned off, they do not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
