omalley commented on a change in pull request #652:
URL: https://github.com/apache/orc/pull/652#discussion_r598921532
##########
File path: java/core/src/java/org/apache/orc/impl/InStream.java
##########
@@ -558,9 +558,14 @@ public void changeIv(Consumer<byte[]> modifier) {
public void seek(PositionProvider index) throws IOException {
boolean seeked = seek(index.getNext());
long uncompressedBytes = index.getNext();
- if (!seeked && uncompressed != null) {
- // Only reposition uncompressed
- uncompressed.position((int) uncompressedBytes);
+ if (!seeked) {
+ if (uncompressed != null) {
+ // Only reposition uncompressed
+ uncompressed.position((int) uncompressedBytes);
+ } else {
Review comment:
I'd drop the empty else block, but the comment is good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
