dongjoon-hyun commented on a change in pull request #670:
URL: https://github.com/apache/orc/pull/670#discussion_r601674413
##########
File path: site/specification/ORCv1.md
##########
@@ -1297,7 +1297,7 @@ in a bloom filter is as follows:
* position = combinedHash % m
6. Set the position in bit set. The LSB 6 bits identifies the long index
within bitset and bit position within the long uses little endian order.
- * bitset[position >>> 6] \|= (1L << position);
+ * bitset[position >> 6] \|= (1L << (position & 0x3f));
Review comment:
Thank you for update. Can we use `% 64` consistently like the code
instead of `& 0x3f`? At line 1297, we already use `%`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
