sv2000 commented on pull request #674:
URL: https://github.com/apache/orc/pull/674#issuecomment-811491607


   @pgaref IIUC, what you are proposing is to have an overloaded constructor in 
OrcMapreduceRecordReader/Writer that accepts rowBatchSize as an argument (like 
we do in this PR), but leave it to the caller to override the getRecordWriter() 
method, which in turn calls the overloaded constructor. This way we don't need 
to introduce a separate config. LMK if I am missing anything. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to