dirtysalt commented on a change in pull request #586:
URL: https://github.com/apache/orc/pull/586#discussion_r608296123
##########
File path: java/core/src/java/org/apache/orc/impl/RunLengthIntegerWriterV2.java
##########
@@ -530,7 +531,7 @@ private void determineEncoding() {
// fallback to DIRECT encoding.
// The decision to use patched base was based on zigzag values, but the
// actual patching is done on base reduced literals.
- if ((brBits100p - brBits95p) != 0 && Math.abs(min) < BASE_VALUE_LIMIT) {
+ if ((brBits100p - brBits95p) != 0) {
Review comment:
Thanks. Look like this is the correct way to resolve the problem instead
of this workaround.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
