wgtmac commented on a change in pull request #688:
URL: https://github.com/apache/orc/pull/688#discussion_r616772247
##########
File path: c++/src/TypeImpl.cc
##########
@@ -609,6 +614,8 @@ namespace orc {
return std::unique_ptr<Type>(new TypeImpl(BINARY));
} else if (category == "timestamp") {
return std::unique_ptr<Type>(new TypeImpl(TIMESTAMP));
+ } else if (category == "timestamp_with_local_time_zone") {
Review comment:
To be consistent with the Java side, the type name literal should remove
the underscores:
[commit](https://github.com/omalley/orc/blob/8289f7d2640833bba46be88941d1013eb2083023/java/core/src/java/org/apache/orc/TypeDescription.java#L124)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
