autumnust commented on a change in pull request #651:
URL: https://github.com/apache/orc/pull/651#discussion_r621639554
##########
File path: java/bench/core/src/java/org/apache/orc/bench/core/IOCounters.java
##########
@@ -48,23 +50,26 @@ public void print() {
if (recordCounters != null) {
recordCounters.print();
}
- System.out.println("Reads: " + reads);
- System.out.println("Bytes: " + bytesRead);
+ System.out.println("io: " + io);
+ System.out.println("Bytes: " + bytesIO);
}
public double bytesPerRecord() {
return recordCounters == null || recordCounters.records == 0 ?
- 0 : ((double) bytesRead) / recordCounters.records;
+ 0 : ((double) bytesIO) / recordCounters.records;
}
public long records() {
return recordCounters == null || recordCounters.invocations == 0 ?
0 : recordCounters.records / recordCounters.invocations;
}
- public long reads() {
+ /**
+ * Capture the number of I/O on average in each invocation.
+ */
+ public long iOs() {
Review comment:
thanks that's a much better name !
##########
File path: java/bench/core/src/java/org/apache/orc/bench/core/IOCounters.java
##########
@@ -48,23 +50,26 @@ public void print() {
if (recordCounters != null) {
recordCounters.print();
}
- System.out.println("Reads: " + reads);
- System.out.println("Bytes: " + bytesRead);
+ System.out.println("io: " + io);
+ System.out.println("Bytes: " + bytesIO);
}
public double bytesPerRecord() {
return recordCounters == null || recordCounters.records == 0 ?
- 0 : ((double) bytesRead) / recordCounters.records;
+ 0 : ((double) bytesIO) / recordCounters.records;
}
public long records() {
return recordCounters == null || recordCounters.invocations == 0 ?
0 : recordCounters.records / recordCounters.invocations;
}
- public long reads() {
+ /**
+ * Capture the number of I/O on average in each invocation.
+ */
+ public long iOs() {
Review comment:
Second thoughts: there's no "per second" so I may just called it `ops`,
wdyt ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
