dongjoon-hyun commented on a change in pull request #695:
URL: https://github.com/apache/orc/pull/695#discussion_r627086996
##########
File path: c++/src/Compression.cc
##########
@@ -353,19 +353,29 @@ DIAGNOSTIC_PUSH
// the current state
DecompressState state;
- // the start of the current buffer
- // This pointer is not owned by us. It is either owned by zstream or
- // the underlying stream.
+ // The starting and current position of the buffer for the uncompressed
+ // data. It either points to the data buffer or the underlying input
stream.
+ const char* outputBufferStart;
const char* outputBuffer;
- // the size of the current buffer
+ // The original (ie. the overall) and the actual length of the uncompressed
+ // data.
+ size_t uncompressedBufferLength;
size_t outputBufferLength;
- // the size of the current chunk
+
+ // The remaining size of the current chunk that is not yet consumed
+ // ie. decompressed or returned in output if state==DECOMPRESS_ORIGINAL
size_t remainingLength;
// the last buffer returned from the input
+ const char* inputBufferStart;
Review comment:
nit. Shall we match with the coding style with the existing line 371 and
372?
```cpp
- const char* inputBufferStart;
+ const char *inputBufferStart;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
