autumnust commented on pull request #651: URL: https://github.com/apache/orc/pull/651#issuecomment-848350035
> > Gentle ping ... @pgaref > > Hey @autumnust thanks for pinging me, got distracted by various tasks last week! > Also thanks for updating the benchmark, this helps a lot. Some comments: > > * I would expect NONE dictImpl bench results to be identical across runs, why is 4096 X 500 run 3x the others? > * Seems like an init size of 4k could be a good default conf in most of the cases -- would it make sense remove the extra conf completely if we can avoid it? > * Minor: I would rename upperBound to distinctCount > > Let me know what you think Hi @pgaref thanks for getting back to me. Yeah the 3x number in 4096 X 500 case is weird as I am no long able to reproduce it. Not sure if it is just some noise since I am running this benchmark locally. I updated the PR for the rest of comments, they all make sense to me, especially the point to keep the configuration minimal ( one of the other projects that I am working on have this problem that results in a lot of confusion from beginner users) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
