pgaref commented on pull request #714:
URL: https://github.com/apache/orc/pull/714#issuecomment-857748790


   > 3
   
   Maybe I did not make myself clear, my point was if we actually need the -1 
part since are already rounding up on the next power or 2.  Taking another look 
this takes care of the equality case ( e.g., 32KB does not need any rounding as 
it will be twice as large).
   
   +1 on the existing changes
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to