belugabehr commented on a change in pull request #741:
URL: https://github.com/apache/orc/pull/741#discussion_r666629598
##########
File path: java/core/src/java/org/apache/orc/impl/ConvertTreeReaderFactory.java
##########
@@ -1068,6 +1068,8 @@ public void nextVector(ColumnVector previousVector,
}
public static class StringGroupFromBooleanTreeReader extends
StringGroupFromAnyIntegerTreeReader {
+ private static final byte[] TRUE_BYTES =
"TRUE".getBytes(StandardCharsets.US_ASCII);
+ private static final byte[] FALSE_BYTES =
"FALSE".getBytes(StandardCharsets.US_ASCII);
Review comment:
The two will produce the same output since all character values
(T,R,U,E,F,A,L,S) are ASCII values. There is slightly less overhead with using
ASCII directly as opposed to using UTF8 which will discover that all values are
ASCII.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
