[GitHub] [orc] belugabehr commented on a change in pull request #754: ORC-852: Allow DynamicByteArray to Return a ByteBuffer

[GitBox]

belugabehr commented on a change in pull request #754:
URL: https://github.com/apache/orc/pull/754#discussion_r676579472



##########
File path: java/core/src/java/org/apache/orc/impl/StringHashTableDictionary.java
##########
@@ -120,6 +122,11 @@ public void getText(Text result, int positionInKeyOffset) {
     DictionaryUtils.getTextInternal(result, positionInKeyOffset, 
this.keyOffsets, this.byteArray);
   }
 
+  @Override
+  public ByteBuffer getText(int positionInKeyOffset) {
+    return DictionaryUtils.getTextInternal(positionInKeyOffset, 
this.keyOffsets, this.byteArray);
+  }

Review comment:
       On the second part, if you are referring to the new value returned by 
`setByteBuffer`, there's no functionality change there.  I am simply returning 
the passed in value for convenience:
   
   ```java
   ByteBuffer bb = ByteBuffer.allocate(16);
   dictionary.setByteBuffer(bb, 0, 16);
   System.out.println(bb);
   
   // v.s.
   
   ByteBuffer bb = ByteBuffer.allocate(16);
   System.out.println(dictionary.setByteBuffer(bb, 0, 16));
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org