pavibhai commented on a change in pull request #773:
URL: https://github.com/apache/orc/pull/773#discussion_r676995945



##########
File path: java/core/src/test/org/apache/orc/impl/TestRecordReaderImpl.java
##########
@@ -310,6 +310,9 @@ public Object getLiteral() {
       return null;
     }
 
+    @Override

Review comment:
       I was wondering if we should add a default implementation to this new 
method into PredicateLeaf. But not required if this is the only failure we are 
seeing.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to