dongjoon-hyun opened a new pull request #783:
URL: https://github.com/apache/orc/pull/783


   ### What changes were proposed in this pull request?
   
   This PR aims to use the package name `CyprusSASL` at 
`find_package_handle_standard_args`.
   ```
   -find_package_handle_standard_args(CYRUS_SASL DEFAULT_MSG
   +find_package_handle_standard_args(CyrusSASL DEFAULT_MSG
   ```
   
   ### Why are the changes needed?
   
   Currently, it shows a warning like the following.
   ```
   CMake Warning (dev) at 
/opt/homebrew/Cellar/cmake/3.21.0/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:438
 (message):
     The package name passed to `find_package_handle_standard_args` (CYRUS_SASL)
     does not match the name of the calling package (CyrusSASL).  This can lead
     to problems in calling code that expects `find_package` result variables
     (e.g., `_FOUND`) to follow a certain pattern.
   Call Stack (most recent call first):
     cmake_modules/FindCyrusSASL.cmake:46 (find_package_handle_standard_args)
     cmake_modules/ThirdpartyToolchain.cmake:432 (find_package)
     CMakeLists.txt:130 (INCLUDE)
   This warning is for project developers.  Use -Wno-dev to suppress it.
   ```
   
   ### How was this patch tested?
   
   Pass the CIs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to