williamhyun commented on a change in pull request #816:
URL: https://github.com/apache/orc/pull/816#discussion_r683061847
##########
File path: java/bench/pom.xml
##########
@@ -468,6 +468,15 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <configuration>
+ <ignoredDependencies>
+ <ignoredDependency>*:*</ignoredDependency>
+ </ignoredDependencies>
+ </configuration>
+ </plugin>
Review comment:
`benchmark` module is not published to the Maven Central.
##########
File path: java/pom.xml
##########
@@ -306,6 +306,22 @@
<failOnViolation>true</failOnViolation>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <version>3.1.2</version>
Review comment:
3.2.x has a bug. So, we should use the latest 3.1.x which is 3.1.2.
##########
File path: java/pom.xml
##########
@@ -306,6 +306,22 @@
<failOnViolation>true</failOnViolation>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <version>3.1.2</version>
+ <executions>
+ <execution>
+ <phase>package</phase>
+ <goals>
+ <goal>analyze-only</goal>
+ </goals>
+ </execution>
+ </executions>
+ <configuration>
+ <failOnWarning>true</failOnWarning>
Review comment:
This will enforce this plugin in `analyze` profile.
##########
File path: java/tools/pom.xml
##########
@@ -62,7 +66,7 @@
</dependency>
<dependency>
<groupId>org.apache.hadoop</groupId>
- <artifactId>hadoop-hdfs</artifactId>
+ <artifactId>hadoop-hdfs-client</artifactId>
Review comment:
After ORC-603 (https://github.com/apache/orc/pull/607), we use
`hadoop-hdfs-client`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
