dongjoon-hyun commented on a change in pull request #847:
URL: https://github.com/apache/orc/pull/847#discussion_r686467716



##########
File path: java/examples/pom.xml
##########
@@ -50,10 +50,12 @@
     <dependency>
       <groupId>org.apache.hadoop</groupId>
       <artifactId>hadoop-common</artifactId>
+      <scope>compile</scope>
     </dependency>
     <dependency>
       <groupId>org.apache.hadoop</groupId>
       <artifactId>hadoop-hdfs</artifactId>
+      <scope>compile</scope>

Review comment:
       BTW, @krystalics . When you make a PR, you had better rebase your branch 
to the latest `main` branch.
   For example, this file is the content of the exiting `main` branch, but it 
seems that GitHub shows this because your PR branch is too old.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to