dongjoon-hyun commented on a change in pull request #887:
URL: https://github.com/apache/orc/pull/887#discussion_r697948360
##########
File path: java/core/src/java/org/apache/orc/impl/RunLengthIntegerWriterV2.java
##########
@@ -545,14 +547,10 @@ private void determineEncoding() {
private void computeZigZagLiterals() {
// populate zigzag encoded literals
- long zzEncVal = 0;
- for (int i = 0; i < numLiterals; i++) {
- if (signed) {
- zzEncVal = utils.zigzagEncode(literals[i]);
- } else {
- zzEncVal = literals[i];
+ if (signed) {
Review comment:
Shall we remove `if` statement and add an assertion at the first line of
this function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
