rip-nsk commented on a change in pull request #903:
URL: https://github.com/apache/orc/pull/903#discussion_r704063853
##########
File path: c++/src/Reader.cc
##########
@@ -385,7 +385,7 @@ namespace orc {
void RowReaderImpl::seekToRowGroup(uint32_t rowGroupEntryId) {
// store positions for selected columns
- std::vector<std::list<uint64_t>> positions;
+ std::list<std::list<uint64_t>> positions;
Review comment:
In my environment (Windows, MSVC 19.12.25835.0),
test DictionaryEncoding.multipleStripesWithIndex failed due to invalid
iterators in positionProviders.
// copy index positions for a specific column
positions.push_back({});
auto& position = positions.back();
for (int pos = 0; pos != entry.positions_size(); ++pos) {
position.push_back(entry.positions(pos)); // iterators
may be invalidated here due to reallocation
}
positionProviders.insert(std::make_pair(colId,
PositionProvider(position))); // iterator taken here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
