+1 (binding)

* Checked sig & checksum
* Ran the docker builds
* Compiled with -Panalyze & -Pbenchmark and -Papache-release

One annoyance is that TestByteRle.cc has a double semicolon that clang
complains about and thus fails the ubuntu 20 with clang build.

diff --git a/c++/test/TestByteRle.cc b/c++/test/TestByteRle.cc
index 2c4d4e3d..cdb9cf2e 100644
--- a/c++/test/TestByteRle.cc
+++ b/c++/test/TestByteRle.cc
@@ -1104,7 +1104,7 @@ TEST(BooleanRle, skipTestWithNulls) {
       rle->skip(4);
     }
     rle->skip(0);
-    data.assign(data.size(), -1);;
+    data.assign(data.size(), -1);
     rle->next(data.data(), data.size(), allNull.data());
     for (size_t j = 0; j < data.size(); ++j) {
       EXPECT_EQ(0, data[j]) << "Output wrong at " << i << ", " << j;


On Tue, Sep 14, 2021 at 5:08 AM Dongjoon Hyun <[email protected]> wrote:

> +1
>
> 1. Shasum and gpg sig checked.
> 2. Built and ran the C++/Java unit tests.
> 3. Tested Java tools uber jar manually.
> 4. Tested Java example uber jar manually.
> 5. Apache Spark integration test passed
>    (RC0 staging + Spark 3.1.3-SNAPSHOT)
>    https://github.com/apache/spark/pull/33972
>
> Dongjoon
>
> On 2021/09/13 03:53:54, Dongjoon Hyun <[email protected]> wrote:
> > Please vote on releasing the following candidate as Apache ORC version
> > 1.5.13.
> >
> > [ ] +1 Release this package as Apache ORC 1.5.13
> > [ ] -1 Do not release this package because ...
> >
> > TAG:
> > https://github.com/apache/orc/releases/tag/release-1.5.13rc0
> >
> > RELEASE FILES:
> > https://dist.apache.org/repos/dist/dev/orc/orc-1.5.13-rc0
> >
> > STAGING REPOSITORY:
> > https://repository.apache.org/content/repositories/orgapacheorc-1050
> >
> > LIST OF JIRA ISSUES:
> > https://issues.apache.org/jira/projects/ORC/versions/12349322
> >
> > This vote will be open for 72 hours.
> >
> > Thanks,
> > Dongjoon.
> >
>

Reply via email to