pavibhai commented on a change in pull request #936:
URL: https://github.com/apache/orc/pull/936#discussion_r728213568
##########
File path: java/core/src/java/org/apache/orc/impl/filter/FilterFactory.java
##########
@@ -74,11 +96,6 @@ public static BatchFilter createBatchFilter(Reader.Options
opts,
}
}
- // 2. Process input filter
- if (opts.getFilterCallback() != null) {
Review comment:
Yeah it feels cleaner that we go from the more specific to the more
generic ones.
1. Input Filter
2. Filter Plugin
3. SArg Filters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
