guiyanakuang commented on a change in pull request #942:
URL: https://github.com/apache/orc/pull/942#discussion_r732468542
##########
File path: java/tools/src/test/org/apache/orc/tools/convert/TestJsonReader.java
##########
@@ -117,10 +117,13 @@ public void testDateTimeTypeSupport() throws IOException {
ZonedDateTime datetime5 = ZonedDateTime.of(datetime1,
ZoneId.of("UTC"));
ZonedDateTime datetime6 = ZonedDateTime.of(datetime2,
ZoneId.of("America/New_York"));
+ String datetime4Str = datetime4.toString();
+ datetime4Str = datetime4Str.substring(0, datetime4Str.length() - 5) +
"0700";
Review comment:
```
- 2021-10-19T07:00:01.683210-07:00
+ 2021-10-19T0700:01.683210-0700
```
@dongjoon-hyun Thanks for the quick review.
`.replace("07:00", "0700")` The original intent was to replace the last 5
characters (time zone), but the exception is that it matches exactly HH:mm
My approach is consistent with its intent and will have no side effects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
