noirello opened a new pull request #959:
URL: https://github.com/apache/orc/pull/959


   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. File a JIRA issue first and use it as a prefix of your PR title, e.g., 
`ORC-001: Fix ABC`.
     2. Use your PR title to summarize what this PR proposes instead of 
describing the problem.
     3. Make PR title and description complete because these will be the 
permanent commit log.
     4. If possible, provide a concise and reproducible example to reproduce 
the issue for a faster review.
     5. If the PR is unfinished, use GitHub PR Draft feature.
   -->
   
   ### What changes were proposed in this pull request?
   Improve parsing schema string with `Type::buildTypeFromString` to handle 
quoted field names and have stricter validations.
   
   ### Why are the changes needed?
   The current implementation cannot handle quoted field names and allows 
parsing string schemas that the Java implementation would reject (e.g. 
`struct<bigint>`, `map(boolean,float)`). It also cannot parse schema with 
`timestamp with local time zone` in the root.
   
   ### How was this patch tested?
   Ran the existing test suites locally with the newly added tests for quoted 
field names and invalid schemas. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to