belugabehr commented on a change in pull request #977: URL: https://github.com/apache/orc/pull/977#discussion_r774861842
########## File path: java/core/src/java/org/apache/orc/TypeDescription.java ########## @@ -420,15 +418,9 @@ public boolean equals(Object other, boolean checkAttributes) { } if (checkAttributes) { // make sure the attributes are the same - List<String> attributeNames = getAttributeNames(); - if (castOther.getAttributeNames().size() != attributeNames.size()) { + if (!this.attributes.equals(castOther.attributes)) { Review comment: The native `Map` equals method implements this already. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org