guiyanakuang commented on a change in pull request #992:
URL: https://github.com/apache/orc/pull/992#discussion_r779355598
##########
File path: java/core/src/test/org/apache/orc/impl/TestRecordReaderImpl.java
##########
@@ -2449,4 +2449,41 @@ public void testSargApplier() throws Exception {
f2.setAccessible(true);
assertFalse((boolean)f2.get(applier1));
}
+
+ @Test
+ public void testCompatibleSpecificationUnofficialFile() throws IOException {
+ // unofficial.orc is a file compatible with the ORC specification,
Review comment:
> What do you mean by `compatible`? Is it because ORC spec doesn't
enforce `min` and `max`?
Yes, the column statistics interface only needs to provide numberOfValues /
hasNull / bytesOnDisk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
