wgtmac commented on pull request #994: URL: https://github.com/apache/orc/pull/994#issuecomment-1007228886
> > Thank you, @guiyanakuang . Now, this PR also fails. :) > > ``` > > Error: Failures: > > Error: TestSelectedVector.testWriteBaseTypeUseSelectedVector:209 expected: <4> but was: <3> > > Error: TestSelectedVector.testWriteComplexTypeUseSelectedVector:358 expected: <4> but was: <1> > > Error: TestSelectedVector.testWriteEncryptionUseSelectedVector:519 expected: <2> but was: <1> > > ``` > > I fix it in [093c2d8](https://github.com/apache/orc/commit/093c2d8fcc23bc006806dbcf38242a80f78ca01d), @wgtmac @dongjoon-hyun Please help to check again : ) Thanks @guiyanakuang for addressing this! I agree with @dongjoon-hyun. You can open a separate PR to submit your test coverage part (even with my part). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
