pgaref commented on a change in pull request #996:
URL: https://github.com/apache/orc/pull/996#discussion_r780676953
##########
File path: java/core/src/test/org/apache/orc/impl/TestRecordReaderImpl.java
##########
@@ -2449,4 +2449,23 @@ public void testSargApplier() throws Exception {
f2.setAccessible(true);
assertFalse((boolean)f2.get(applier1));
}
+
+ @Test
+ public void testRgEndOffset() throws IOException {
+ Configuration conf = new Configuration();
+ Path filePath = new Path(getClass().getClassLoader().
+ getSystemResource("orc-small-compression-size.orc").getPath());
+ Reader reader = OrcFile.createReader(filePath,
OrcFile.readerOptions(conf));
+
+ SearchArgument sarg = SearchArgumentFactory.newBuilder()
+ .startNot()
+ .lessThan("x", PredicateLeaf.Type.LONG, 120000L)
+ .end().build();
+ VectorizedRowBatch batch = reader.getSchema().createRowBatch();
+ try (RecordReader rows = reader.rows(reader.options().searchArgument(sarg,
null))) {
+ while (rows.nextBatch(batch)) {
+ // do nothing but check all the data can be read
Review comment:
+1 -- it would be much easier if we generate the data as well making
sure there are no inconsistencies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
