dongjoon-hyun commented on a change in pull request #992:
URL: https://github.com/apache/orc/pull/992#discussion_r780725146
##########
File path: java/core/src/java/org/apache/orc/impl/RecordReaderImpl.java
##########
@@ -462,8 +483,30 @@ public long getNext() {
this(predicate, null, null, hasNulls, false, false);
}
+ ValueRange(PredicateLeaf predicate, boolean hasNulls, boolean hasValue,
boolean comparable) {
+ this(predicate, null, null, hasNulls, false, false, hasValue,
comparable);
+ }
+
boolean hasValues() {
- return lower != null;
+ return hasValue;
+ }
+
+ /**
+ * Whether min or max is provided for comparison
+ * @return is it comparable
+ */
+ boolean comparable() {
+ return hasValue && comparable;
+ }
+
+ /**
+ * value range is invalid if the column statistics are non-existent
+ * @see ColumnStatisticsImpl#isStatsExists()
+ * this method is similar to isStatsExists
+ * @return value range is valid or not
+ */
+ boolean valid() {
Review comment:
`valid` -> `isValid`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
