zhanglistar commented on a change in pull request #1010:
URL: https://github.com/apache/orc/pull/1010#discussion_r784558884
##########
File path: c++/include/orc/Exceptions.hh
##########
@@ -30,7 +30,7 @@ namespace orc {
public:
explicit NotImplementedYet(const std::string& what_arg);
explicit NotImplementedYet(const char* what_arg);
- virtual ~NotImplementedYet() ORC_NOEXCEPT;
+ virtual ~NotImplementedYet() ORC_NOEXCEPT override;
Review comment:
> Basically, we prefer to disable warnings in order to avoid code
changes if possible, @zhanglistar .
Alright, I will rollback this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
