dongjoon-hyun commented on a change in pull request #1023:
URL: https://github.com/apache/orc/pull/1023#discussion_r791207092
##########
File path: c++/src/TypeImpl.cc
##########
@@ -413,6 +413,8 @@ namespace orc {
std::unique_ptr<Type> convertType(const proto::Type& type,
const proto::Footer& footer) {
std::unique_ptr<Type> ret;
+ //check for corrupt footers before conversion
+ checkProtoTypes(footer);
Review comment:
Could you describe what happens after this PR? Previously, you filed an
issue with `it crashed`.
##########
File path: c++/src/TypeImpl.cc
##########
@@ -413,6 +413,8 @@ namespace orc {
std::unique_ptr<Type> convertType(const proto::Type& type,
const proto::Footer& footer) {
std::unique_ptr<Type> ret;
+ //check for corrupt footers before conversion
+ checkProtoTypes(footer);
Review comment:
Could you describe what happens after this PR? Previously, you filed the
issue with `it crashed`.
##########
File path: c++/src/TypeImpl.cc
##########
@@ -413,6 +413,8 @@ namespace orc {
std::unique_ptr<Type> convertType(const proto::Type& type,
const proto::Footer& footer) {
std::unique_ptr<Type> ret;
+ //check for corrupt footers before conversion
+ checkProtoTypes(footer);
Review comment:
Could you add some description into this PR's PR description about what
happens after this PR? Previously, you filed the issue with `it crashed`.
##########
File path: c++/src/TypeImpl.cc
##########
@@ -413,6 +413,8 @@ namespace orc {
std::unique_ptr<Type> convertType(const proto::Type& type,
const proto::Footer& footer) {
std::unique_ptr<Type> ret;
+ //check for corrupt footers before conversion
+ checkProtoTypes(footer);
Review comment:
Please put it into the PR description instead of commenting here.
The PR description will be a commit message later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
