stiga-huang commented on a change in pull request #1062:
URL: https://github.com/apache/orc/pull/1062#discussion_r825893418
##########
File path: c++/include/orc/Common.hh
##########
@@ -34,6 +34,7 @@ namespace orc {
public:
static const FileVersion& v_0_11();
static const FileVersion& v_0_12();
+ static const FileVersion& UNSTABLE_PRE_2_0();
Review comment:
Sorry that I don't understand this comment. Are you suggesting adding a
check for this version instead of introducing an unstable version?
BTW, I use the same name we used in Java:
https://github.com/apache/orc/blob/77b4d5acb58e03d50503d1b687421cac627a6e0b/java/core/src/java/org/apache/orc/OrcFile.java#L79
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
